Recent changes to patches

Patch for TFS Support

Christian Eitner — Mon, 05 Sep 2016 14:41:00 -0000

as discussed, here the proposed patch for TFS support
changelog and documentation have been updated
version number incremented tentatively

Mysql Socket Problem

Hemant — Fri, 09 Sep 2011 05:22:59 -0000

I am trying to get a codestriker server up using with mysql as database.
The mysql repository is in custom path instead of the standard path. I have modified the /etc/my.conf to read
<snip>
[client]
socket=/srv/mysql/mysql.sock

[mysqld]
datadir=/srv/mysql
socket=/srv/mysql/mysql.sock
</snip>

It works fine with the local mysql client.

However when I try to run install.pl in codestriker I get the following error:

DBI connect('dbname=codestrikerdb','codestriker',...) failed: Can't connect to local MySQL server through socket '/var/lib/mysql/mysql.sock' (13) at /var/www/codestriker/codestriker-1.9.10/lib/Codestriker/DB/Database.pm line 61

I am not able to proceed further due to this error.

Expected behavior: Codestriker should try to connect to any mysql socket instead of the default one.

ClearCaseSerialDiff.pm repository matching function

Lee Ballard — Wed, 08 Dec 2010 19:21:58 -0000

fixed the simple repository matching function in ClearCaseSerialDiff.pm

parallel view using clearcase snapshot on linux broken

Lee Ballard — Wed, 08 Dec 2010 19:15:51 -0000

for Bug ID 3111991

using clearcase snapshot view on RHEL4.8 I see the following error when I click on parallel links:

Can't close(): Bad file descriptor at /var/www/codestriker/codestriker-1.9.10/lib/Codestriker/Action/ViewTopicFile.pm line 66

Here is the source of the problem. After making this change it works fine

--------------- lib/Codestriker/Repository/ClearCaseSnapshot.pm ---------------
index 42e530d..3c74341 100644
@@ -59,13 +59,14 @@ sub retrieve ($$$\$) {
push @ctArgs, $full_element_name;
Codestriker::execute_command(\*STDERR, \*STDERR, $Codestriker::cleartool, @ctArgs);

+ my $input_fh = new FileHandle;
open(my $input_fh, "<", $tempfile);
for (my $i = 1; <$input_fh>; $i++) {
$_ = Codestriker::decode_topic_text($_);
chop;
$$content_array_ref[$i] = $_;
}
- close <$input_fh>;
+ close $input_fh;

if (defined($tempdir)) {
unlink $errorfile;

Improved ClearCase dynamic view support

Tobias Mieth — Thu, 05 Nov 2009 10:33:10 -0000

As i have already suggest in my yesterdays comment, the current (1.9.10) ClearCaseDynamic.pm has some issues.

1.) getDiff() in ClearCaseDynamic.pm should use CodeStriker::isWindows()
in order to determine if its running on windows, because CtCmd::setview
doesn't work on windows (see retrieve() on how it is done there)

2.) if only one tag is specified the getDiff() method should not return a
diff to the elements predecessor instead it should pull the entire element
from clearcase (this guarantees the same behaviour as in the Subversion.pm for
example)

Therefore i have slightly adjusted the ClearCaseDynamic.pm file and added support for retrieval by a single tag and fixed that path issue.

Tobias

Tag support for Clearcase dynamic view

Lakshmivaragan — Wed, 22 Jul 2009 12:10:21 -0000

The Tag support clearcase dynamic view support has been added.
The start-tag and end-tag can be provided to fetch the file info directly from clearcase.
No need for getting the diff of two version and then uploading it while creating Topic.

Changes done: ClearCaseDynamic.pm
Added functionality for getDiff()

Allow using URLs with parameters as viewers

Vadim Zeitlin — Sat, 16 Aug 2008 20:27:45 -0000

This is similar to patch 1710760 except that this allows to use URLs with parameters for svn repositories. A typical example (and why I needed this):

$file_viewer =
{
'svn:file:///var/svn/project/trunk' => 'http://some.whe.re/cgi-bin/viewvc.cgi/trunk/?root=Project&view=markup',
};

The patch is attached but here it is also inline for ease of review:

--- codestriker-1.9.6-orig/lib/Codestriker/Repository/Subversion.pm 2008-08-16 22:00:29.000000000 +0200
+++ codestriker/lib/Codestriker/Repository/Subversion.pm 2008-08-16 22:22:26.000000000 +0200
@@ -103,5 +103,16 @@
}

- return (defined $viewer) ? $viewer . "/" . $filename : "";
+ return "" unless defined $viewer;
+
+ # check for parameters in the URL: if we have them, the file name must be
+ # inserted before them; otherwise we simply append it to the end
+ if ( $viewer =~ /^([^?]+)(\?.*)$/ ) {
+ $viewer = $1 . $filename . $2;
+ }
+ else {
+ $viewer .= '/' . $filename;
+ }
+
+ return $viewer;
}

Thanks!

Use filename@REV when using SVN 1.5

Charles Lechasseur — Fri, 01 Aug 2008 16:40:29 -0000

This patch detects SVN version in Subversion.pm and if using SVN 1.5, we use

svn cat filename@REV

instead of

svn cat --revision REV filename

This seems to work in all cases and there are cases where the latter doesn't work (particularly in cases where the file's path has been moved/deleted at some later point in the repository's lifetime).

Patch to view comments bound to non-deltas with context

Charles Lechasseur — Thu, 31 Jul 2008 20:08:36 -0000

This patch allows comments bound to a line that isn't part of a delta to be viewable with context in the Topic Comments screen (context is pulled from the file's content in the repository). In particular, binding a comment to a line that was before the first delta in a file broke CodeStriker when trying to view topic comments with context; fixed with this patch also.

Fix "use of uninitialized variable" when accessing SVN

Charles Lechasseur — Thu, 31 Jul 2008 20:03:50 -0000

Generating topics using SVN used to print some "use of uninitialized variable" warnings at the top of the page... I fixed it by initializing a variable... thought I'd post this patch in case you want to merge it.