Recent changes to patches

#1 Folder name tab title etc.

Vivian De Smedt — Fri, 18 Oct 2013 20:09:38 -0000

John,

I noticed that the part of the patch that toggle the menu bar induce a strange behavior when we we switch from application using the Alt+Tab key sequence.

In the coming version of Console I will deactivate the patch. If you submit a fix for this problem I will of course try to merge it back in the coming release.

Best regards,
Vivian.

#1 Folder name tab title etc.

John Peterson — Tue, 07 May 2013 23:36:20 -0000

A reply is posted at https://github.com/mirror/console-devel/pull/1

#1 Folder name tab title etc.

John Peterson — Sun, 02 Dec 2012 12:46:11 -0000

A reply is posted "in the pull requested linked above."

#1 Folder name tab title etc.

Vivian De Smedt — Sun, 02 Dec 2012 12:05:25 -0000

John, You described your patch as: ! Tab title is console title if not null, otherwise current folder: command. ! Command separator is : instead of -. ! Use WS_MAXIMIZEBOX because it's a requirement for Windows 7 automatic window arrangement. + Alt key toggles menu. - m_strTitle, SetTitle, OnEditRenameTab because of no or limited use. Maybe could you split into 5 patches, such that we can review them an accept them individually. We try to document our changes such that we can explain to Kyril what have been done is that branch such that he can take decision for the main branch. If you could justify a bit more the reasons behind your patch that would help to have arguments to push them forward. Why you want to be change the behaviour of the tab title? How could we make it backward compatible? What you want the command separator to be ':' instead of '-' What is the benefits of WS_MAXIMIZEBOX ? What do you mean by "m_strTitle, SetTitle, OnEditRenameTab because of no or limited use" ? Thanks again for your interest for Console-devel and for your patch proposition. Best regards, Vivian. PS: you ask me to set your user for your Ohloh counter, I'm not I know how to do it. Maybe could you drop some explanation such that I do the things correctly :-)

#1 Folder name tab title etc.

Vivian De Smedt — Sun, 11 Nov 2012 07:51:44 -0000

Hi John, Sorry for this late review. We are still learning about the possibilities of Source Forge. Could you explain us a bit more your patch. - What feature it add? - What but it solve? I have the impression that you have worked on more than one topic. Could you split your patch unique feature patches such that we can take individual decisions about its parts? Best regards, Vivian.

Vivian De Smedt — Mon, 10 Sep 2012 13:27:53 -0000