Recent changes to patches

#44 Fix Qt detection when qmake prints extra lines

Leon Bottou — Fri, 07 Oct 2022 00:14:46 -0000

status: open --> closed

Fix Qt detection when qmake prints extra lines

Daniel Nachun — Thu, 06 Oct 2022 02:50:26 -0000

We have encountered a build failure in Homebrew on macOS when building djview4 that occurs because it fails to detect the Qt version properly. The cause of this seems to be that in certain configurations, possibly when multiple Xcode installations are present, qmake returns prints additional lines to stderr. The exected output from qmake is a line that begins with "Project MESSAGE:". To fix the configuration, I have modified the test to use grep to only keep lines that begin with "Project MESSAGE:" before piping this to sed.

Fix Qt detection when qmake prints extra lines

Daniel Nachun — Thu, 06 Oct 2022 02:50:26 -0000

Ticket 44 has been modified: Fix Qt detection when qmake prints extra lines
Edited By: Leon Bottou (leonb)
Status updated: 'open' => 'closed'

#42 djview: formatting text annotations left aligned instead of centered

Leon Bottou — Sun, 11 Jul 2021 13:51:03 -0000

status: open --> accepted

command line tool for extracting a set of pages from a djvu document

Roland Winkler — Mon, 07 Jun 2021 23:27:39 -0000

Djview allows one to extract a range of pages from a djvu document and save them as a new file. I wanted to do this with a command-line tool so that this can become part of a shell script. So I ended up with the file djvusave.cpp attached below. Maybe this is useful for others, too. I am not very good with C++. So I just copy&pasted this code that can probably be improved.

PS: I am more familiar with hacking elisp for Emacs where I wrote djvu.el in GNU Elpa. Thanks for djvu!

djview: formatting text annotations left aligned instead of centered

Roland Winkler — Mon, 07 Jun 2021 23:11:39 -0000

Djview puts text annotations into boxes where the lines are centered. For some time, I have been using the patch attached below that formats the lines left-aligned which I find easier to read. It would be nice if this patch can be included in the code base. Then I need not patch and compile djview anymore each time I upgrade my computer.
Thanks a lot for djvu!

djview: formatting text annotations left aligned instead of centered

Roland Winkler — Mon, 07 Jun 2021 23:11:39 -0000

Ticket 42 has been modified: djview: formatting text annotations left aligned instead of centered
Edited By: Leon Bottou (leonb)
Status updated: 'open' => 'accepted'

#41 djview4 color PDF export results in a blank page

Adam Richter — Wed, 22 Jul 2020 12:21:54 -0000

Hi, again, Leon. If you have not done so already and would not prefer to do so yourself, I would like to notify the upstream libtiff developers of your djvu tiff2pdf.c change in the discussion at https://gitlab.com/libtiff/libtiff/-/issues/1 and suggest they consider merging your patch. Of course, if you would prefer to handle that, that would be even better, but I appreciate the time you have already invested in producing your patch and am trying to minimize my imposition on your time. So, you do not indicate in the next couple of days that I should do otherwise, I will go ahead and bring up your patch (and fully credit you, of course) to the libtiff developers. Thank you for your help! --Adam

#41 djview4 color PDF export results in a blank page

Adam Richter — Tue, 14 Jul 2020 19:08:26 -0000

Thank you so much, Leon, for your super fast turnaround on this and the education about JPEG, TIFF and PDF. I am relieved that someone who knows these formats was able to determine what is apparently a much more correct fix. Thanks also for pushing your change to the git repository so quickly. I have fetched the change, rebuilt, and confirm that your version works for me.

Thanks also to Barak Pearlmutter for his guidance and input on how to proceed with submitting this bug. I hopefully look forward to this fix propagating into Debian-based packaging of djvu that I understand Barak maintains.

Adam

#40 Fix building with the Microsoft compiler

Leon Bottou — Tue, 14 Jul 2020 15:45:50 -0000

Description has changed:

Diff:

--- old
+++ new
@@ -0,0 +1 @@
+accepted

status: open --> closed