Recent changes to patches

#270 martabak paling enak

2019-09-26T11:45:41.726000Z

https://sourceforge.net/p/tips-dan-trik/blog/2019/09/game-offline-android-terbaik/

martabak paling enak

2015-05-11T16:08:13.079000Z

Bingung mencari camilan saat sibuk di kantor, mungkin Martabak Orins, martabak paling enak di Jakarta, bisa menjadi pilihan bagi anda yang doyan ngemil di sela-sela kesibukan bekerja, karena selain rasanya yang nikmat layanan pesan antar merupakan jasa unggulan yang ditawarkan pengelola jajanan ini. Yang membedakan martabak ini dengan martabak lainya adalah tektur adonannya yang lembut serta pilihan beragam toping yang bisa disesuaikan dengan selera, mulai coklat kacang wijen, pisang coklat hingga kombinasi keju kacang dan coklat yang disajikan tanpa melipat layaknya martabak-martabak lain sehingga terlihat seperti sajian Pizza, hal inilah yang menjadikan martabak Orins punya ciri tersendiri.

RSS thumbnail image URL fix

2010-03-26T04:32:48Z

This patch is for Gallery v2.3.1.

While attempting to add an image RSS feed to my Google Profile, I noticed that all the images in the widget were 'clickable' but not showing their respective thumbnails. Digging a bit deeper, it appeared that when using Media RSS tags, the thumbnail URL was being set to the actual link within the gallery, and not the img src link.

I searched through the bug entries, and found <a target="_blank" href="https://sourceforge.net/tracker/index.php?func=detail&aid=2541381&group_id=7130&atid=107130">Bug #: 2541381</a> which was opened for the same issue. I wasn't sure if bubbawilson's fix was correct, so I came up with my own which made the change in RssGenerator.class, instead of RssHelper.class

In addition to fixing the image URL, I also added the image type which was missing.

After applying the fix, and testing it, the Google widget showed the correct thumbnail image, and once clicked, brought me to the correct gallery link for the full image.

Native MS SQL Server Support

2010-01-28T22:40:56Z

Currently Gallery 2 only supports the community mssql driver for php, (via ADOdb).

Our team has created an ADODB driver package that uses the Native SQL Server driver for PHP which was recently released by Microsoft (currently in v1.1).

More information regarding the Native SQL Server driver for PHP can be found here:

http://www.microsoft.com/downloads/details.aspx?FamilyId=61BF87E0-D031-466B-B09A-6597C21A2E2A&displaylang=en

I've attached the full patch file that adds Native SQL Server support to Gallery 2 to this request and would love to work with the developers/maintainers in order to have this package officially supported.

Bug in GalleryDataCache::putPageData()

2009-12-22T17:43:56Z

There is a bug in GalleryDataCache::putPageData() that causes a database error when two requests for the same page are sent within one second. (Double click on the "next-image" Button or on the browser reload button.)

The problem is that $storage->getAffectedRows() after updateMapEntry only returns 1 if any data has actually been changed!
This seems to be a known problem in mysqli:
http://www.databasesandlife.com/mysqli_affected_rows/

If the second UPDATE comes within the same second, the values to update are identically to the values that have already been written by the first request. So $storage->getAffectedRows() thinks that the UPDATE didn't match any row and tries an INSERT. This, of course fails, another UPDATE is done, which yields affectedRows=0 again. And the second INSERT causes the ERROR_STORAGE_FAILURE.

This error applys at least to systems using the mysql or mysqli database driver.

Unfortunately there is no database independent way of getting the number of rows matched (as opposed to the number of rows changed) by the the UPDATE in GalleryCoreApi::updateMapEntry().

The attached suboptimal patch fixes the problem for now.

Fix another "new by reference" warning in PHP 5.3

2009-11-20T19:20:46Z

PHP 5.3 / G2 svn trunk brings this warning:
"Deprecated: Assigning the return value of new by reference is deprecated in /var/www/localhost/htdocs/gc/modules/gd/classes/GdToolkitHelper.class on line 388 "

Most such warnings are fixed in svn, this was probably forgotten. Patch attached.

Replace split calls for php 5.3

2009-11-20T18:50:52Z

PHP 5.3 brings deprecation warnings on split. All split calls should be replaced by preg_split (if they need regexp functionality) or explode (if they don't need regexps, which is also faster).

I've done this for most of the split-appearences in g2 svn trunk. Though there are five left that I was unsure about. I'll have a deeper look at them later.

Please apply attached patch.

Escaping command args in UnixPlatform.class

2009-08-13T15:04:16Z

Hi,
First thank you for your work.
In UnixPlatform.class, command arguements are escaped using double quotes, but, it's not safe, a better way is using escapeshellarg(). In addition, with escapeshellargs, it's become safe mode/ exec_dir patch compatible.

You can found in attachment the patch.
Hope it will be include in the next release
Regards

Cédric

http://www.php.net/escapeshellarg

cart: add to cart redirects to the original page

2009-05-13T22:08:28Z

Old behavior: Click on “add a photo to cart” makes gallery to jump to the cart.
New behavior: Click on “add a photo to cart” jumps to the current page.

See also
* http://gallery.menalto.com/node/77813
* tracker #1799278)

[G2] HTTP_RANGE iPhone Video Patch

2009-03-20T18:41:30Z

This patch provides http_range support for item downloads. The primary reason for this patch is to allow videos to play on the iPhone but should allow for better streaming of video and audio to devices that support it.

This patch was adapted from the solution provided by Arnoldjw ( http://gallery.menalto.com/node/84561 ) in the forums.