gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

D.Kartaschew — Wed, 01 Jan 2025 04:55:27 -0000

Thanks for letting me know.

gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

Immolo — Wed, 01 Jan 2025 04:53:14 -0000

I'm more than happy to be the middle man, however that last patch fixed all the issues so thank you very much and I'll get into Gentoo ASAP.

gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

D.Kartaschew — Wed, 01 Jan 2025 04:32:19 -0000

Hi, no problem. I just assumed you were busy with the holiday period.

Try the new given patch, that should correct the errors in the build log.
Unfortunately I don't have access to a build system to build gmtp currently, so patches may not be 100%.

Happy new year to you as well.

gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

Immolo — Wed, 01 Jan 2025 02:01:37 -0000

Apologises , I've been feeling a little under the weather and not got around to testing the patch till today.

This turns the issue into:

include/gdk-pixbuf-2.0 -I/usr/include/webp -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/atk-1.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/elogind -I/usr/include/fribidi -I/usr/include/libpng16 -I/usr/include/pixman-1 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/gio-unix-2.0 -I/usr/lib64/libffi/include -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/libusb-1.0  -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include     -O2 -march=native -pipe -flto -Wall -Wextra -Wpedantic  -c -o gmtp-interface.o `test -f 'interface.c' || echo './'`interface.c
interface.c: In function ‘create_windowMain’:
interface.c:744:19: error: passing argument 1 of ‘setupFileList’ from incompatible pointer type [-Wincompatible-pointer-types]
  744 |     setupFileList(treeviewFiles);
      |                   ^~~~~~~~~~~~~
      |                   |
      |                   GtkWidget * {aka struct _GtkWidget *}
interface.c:43:33: note: expected ‘GtkTreeView *’ {aka ‘struct _GtkTreeView *’} but argument is of type ‘GtkWidget *’ {aka ‘struct _GtkWidget *’}
   43 | void setupFileList(GtkTreeView *treeviewFiles);
      |                    ~~~~~~~~~~~~~^~~~~~~~~~~~~
interface.c: In function ‘fileListDownload’:
interface.c:1939:34: warning: cast between incompatible function types from ‘void (*)(GtkTreeRowReference *)’ {aka ‘void (*)(struct _GtkTreeRowReference *)’} to ‘void (*)(void *, void *)’ [-Wcast-function-type]
 1939 |             g_list_foreach(List, (GFunc) __fileDownload, NULL);
      |                                  ^
interface.c:1945:30: warning: cast between incompatible function types from ‘void (*)(GtkTreeRowReference *)’ {aka ‘void (*)(struct _GtkTreeRowReference *)’} to ‘void (*)(void *, void *)’ [-Wcast-function-type]
 1945 |         g_list_foreach(List, (GFunc) __fileDownload, NULL);
      |                              ^
interface.c: In function ‘fileListRemove’:
interface.c:2124:26: warning: cast between incompatible function types from ‘void (*)(GtkTreeRowReference *)’ {aka ‘void (*)(struct _GtkTreeRowReference *)’} to ‘void (*)(void *, void *)’ [-Wcast-function-type]
 2124 |     g_list_foreach(List, (GFunc) __fileRemove, NULL);
      |                          ^
interface.c: In function ‘folderListRemove’:
interface.c:2169:26: warning: cast between incompatible function types from ‘void (*)(GtkTreeRowReference *)’ {aka ‘void (*)(struct _GtkTreeRowReference *)’} to ‘void (*)(void *, void *)’ [-Wcast-function-type]
 2169 |     g_list_foreach(List, (GFunc) __folderRemove, NULL);
      |                          ^
interface.c: In function ‘fileListGetSelection’:
interface.c:2301:35: warning: cast between incompatible function types from ‘void (*)(GtkTreePath *)’ {aka ‘void (*)(struct _GtkTreePath *)’} to ‘void (*)(void *, void *)’ [-Wcast-function-type]
 2301 |     g_list_foreach(selectedFiles, (GFunc) gtk_tree_path_free, NULL);
      |                                   ^
make[2]: *** [Makefile:536: gmtp-interface.o] Error 1
make[2]: Leaving directory '/var/tmp/portage/media-sound/gmtp-1.3.11-r3/work/gmtp-1.3.11/src'
make[2]: *** Waiting for unfinished jobs....

and a few more as included in the full log. As a note you can add --std=gnu23 while compile to get the same strictness on a previous version of GCC.

Also happy new year to you.

gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

D.Kartaschew — Fri, 27 Dec 2024 06:39:33 -0000

Try this new patch.
I think 'treeviewFolders' needs a cast on line 716 for it to be happy.

gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

Immolo — Fri, 27 Dec 2024 06:17:19 -0000

It's a shame to hear that.

Thanks for the patch though however this changed the error to

x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I..     -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/webp -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/atk-1.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/elogind -I/usr/include/fribidi -I/usr/include/libpng16 -I/usr/include/pixman-1 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/gio-unix-2.0 -I/usr/lib64/libffi/include -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/libusb-1.0  -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include     -O2 -march=native -pipe -flto -Wall -Wextra -Wpedantic  -c -o gmtp-interface.o `test -f 'interface.c' || echo './'`interface.c
interface.c: In function ‘create_windowMain’:
interface.c:716:36: error: passing argument 1 of ‘setupFolderList’ from incompatible pointer type [-Wincompatible-pointer-types]
  716 |     folderColumn = setupFolderList(treeviewFolders);

gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

D.Kartaschew — Fri, 27 Dec 2024 05:49:50 -0000

Hi, Thanks for reporting, however gmtp isn't being worked on currently. (I've switched from running OpenIndiana, so have no need for this tool personally, so any maintenance may no longer happen).
I however have created the following patch for the 1.3.11 release that should allow it to compile when C23 is being enforced. Let me know if it fixes the compile issue, or if additional patches are needed.

gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

Immolo — Thu, 26 Dec 2024 17:46:55 -0000

Downstream bug: https://bugs.gentoo.org/945202

gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

Immolo — Thu, 26 Dec 2024 17:46:30 -0000

With the upcoming release of GCC15, it will be enforcing C23 standards in code which results in gMTP no longer compiling.

x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I..     -I/usr/include/gtk-3.0 -I/usr/include/pango-1.0 -I/usr/include/cairo -I/usr/include/gdk-pixbuf-2.0 -I/usr/include/webp -I/usr/include/at-spi2-atk/2.0 -I/usr/include/at-spi-2.0 -I/usr/include/atk-1.0 -I/usr/include/dbus-1.0 -I/usr/lib64/dbus-1.0/include -I/usr/include/elogind -I/usr/include/fribidi -I/usr/include/libpng16 -I/usr/include/pixman-1 -I/usr/include/harfbuzz -I/usr/include/freetype2 -I/usr/include/gio-unix-2.0 -I/usr/lib64/libffi/include -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/libmount -I/usr/include/blkid -I/usr/include/libusb-1.0  -pthread -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include     -O2 -march=native -pipe -flto -Wall -Wextra -Wpedantic  -c -o gmtp-interface.o `test -f 'interface.c' || echo './'`interface.c
interface.c: In function ‘create_windowMain’:
interface.c:716:20: error: too many arguments to function ‘setupFolderList’; expected 0, have 1
  716 |     folderColumn = setupFolderList(treeviewFolders);
      |                    ^~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~
interface.c:44:20: note: declared here
   44 | GtkTreeViewColumn *setupFolderList();
      |                    ^~~~~~~~~~~~~~~
interface.c:744:5: error: too many arguments to function ‘setupFileList’; expected 0, have 1
  744 |     setupFileList(treeviewFiles);
      |     ^~~~~~~~~~~~~ ~~~~~~~~~~~~~
interface.c:43:6: note: declared here
   43 | void setupFileList();
      |      ^~~~~~~~~~~~~
interface.c: At top level:
interface.c:1040:6: error: conflicting types for ‘setupFileList’; have ‘void(GtkTreeView *)’ {aka ‘void(struct _GtkTreeView *)’}
 1040 | void setupFileList(GtkTreeView *treeviewFiles) {
      |      ^~~~~~~~~~~~~
interface.c:43:6: note: previous declaration of ‘setupFileList’ with type ‘void(void)’
   43 | void setupFileList();
      |      ^~~~~~~~~~~~~
interface.c:1325:20: error: conflicting types for ‘setupFolderList’; have ‘GtkTreeViewColumn *(GtkTreeView *)’ {aka ‘struct _GtkTreeViewColumn *(struct _GtkTreeView *)’}
 1325 | GtkTreeViewColumn *setupFolderList(GtkTreeView *treeviewFolders) {
      |                    ^~~~~~~~~~~~~~~
interface.c:44:20: note: previous declaration of ‘setupFolderList’ with type ‘GtkTreeViewColumn *(void)’ {aka ‘struct _GtkTreeViewColumn *(void)’}
   44 | GtkTreeViewColumn *setupFolderList();
      |                    ^~~~~~~~~~~~~~~
interface.c: In function ‘fileListDownload’:
interface.c:1939:34: warning: cast between incompatible function types from ‘void (*)(GtkTreeRowReference *)’ {aka ‘void (*)(struct _GtkTreeRowReference *)’} to ‘void (*)(void *, void *)’ [-Wcast-function-type]
 1939 |             g_list_foreach(List, (GFunc) __fileDownload, NULL);
      |                                  ^
interface.c:1945:30: warning: cast between incompatible function types from ‘void (*)(GtkTreeRowReference *)’ {aka ‘void (*)(struct _GtkTreeRowReference *)’} to ‘void (*)(void *, void *)’ [-Wcast-function-type]
 1945 |         g_list_foreach(List, (GFunc) __fileDownload, NULL);
      |                              ^
interface.c: In function ‘fileListRemove’:
interface.c:2124:26: warning: cast between incompatible function types from ‘void (*)(GtkTreeRowReference *)’ {aka ‘void (*)(struct _GtkTreeRowReference *)’} to ‘void (*)(void *, void *)’ [-Wcast-function-type]
 2124 |     g_list_foreach(List, (GFunc) __fileRemove, NULL);
      |                          ^
interface.c: In function ‘folderListRemove’:
interface.c:2169:26: warning: cast between incompatible function types from ‘void (*)(GtkTreeRowReference *)’ {aka ‘void (*)(struct _GtkTreeRowReference *)’} to ‘void (*)(void *, void *)’ [-Wcast-function-type]
 2169 |     g_list_foreach(List, (GFunc) __folderRemove, NULL);
      |                          ^
interface.c: In function ‘fileListGetSelection’:
interface.c:2301:35: warning: cast between incompatible function types from ‘void (*)(GtkTreePath *)’ {aka ‘void (*)(struct _GtkTreePath *)’} to ‘void (*)(void *, void *)’ [-Wcast-function-type]
 2301 |     g_list_foreach(selectedFiles, (GFunc) gtk_tree_path_free, NULL);
      |                                   ^
make[2]: *** [Makefile:536: gmtp-interface.o] Error 1
make[2]: Leaving directory '/var/tmp/portage/media-sound/gmtp-1.3.11-r3/work/gmtp-1.3.11/src'
make[2]: *** Waiting for unfinished jobs....

See https://wiki.gentoo.org/wiki/Modern_C_porting#bool for more info

Error when uploading files with a question mark in the name

Journeyman — Tue, 30 Jan 2024 10:05:18 -0000

Using a Google Nexus Pixel 4a and gMTP 3.11 (Debian package) I cannot upload files with a question mark in the name. Here what I see in the console:

$ gmtp
Device 0 (VID=18d1 and PID=4ee1) is a Google Inc Nexus/Pixel (MTP).
Android device detected, assigning default bug flags
Error sending file /home/me/file?.txt.
Error 2: PTP Layer error 2002: LIBMTP_Send_File_From_File_Descriptor(): Could not send object.
Error 2: Error 2002: PTP General Error

Renaming the file and removing the '?' before uploading to the device is the current workaround.

Recent posts to Discussion

gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

gmtp-1.3.11-r3 fails to compile: interface.c:716:20: error: too many arguments to function setupFolderList

Error when uploading files with a question mark in the name