Recent changes to patches

fix exception on first run

Sebastian Reitenbach — Mon, 06 Jun 2011 09:27:10 -0000

Attached patch fixes an exception in Burn, when it is started for the first time. After dismissing the splash screen, then it fails to load the Gorm file, due to an excpetion that GSDictionary doesn't know about setObject: forKey:, because its an empty dictionary.
Attached patch checks whether the dictionary has 0 elements, and then omits the setting of the value.

allow burning CDs on OpenBSD, and prevent a crash

Sebastian Reitenbach — Mon, 06 Jun 2011 09:22:34 -0000

Attached patch allows me to burn CDs on OpenBSD. Also tested with the patch on Linux, which still works.

The transports array is changed a bit, now including the colon, and device names for OpenBSD /dev/cd0c for example. On OpenBSD, the scan of the scsi-bus is not supported by cdrecord. Therefore the device names are added to the list. Later, where the transports are used, the code was modified to work with the changed transports. Note, this is only tested with one drive in a box.

The hunk in the diff at @@ -293,6 +301,7 is to prevent a crasher I have seen on OpenBSD and on Linux. It always calculates maxTrackProgress as 0 for me. I don't know what magic numbers are used in the calculation, therefore I just set this to 100, which is definitely not right.

garbage displayed on first startup

Sebastian Reitenbach — Mon, 06 Jun 2011 09:13:07 -0000

With the English and French localization, the wrong placeholder is used in the string, %s instead of %@.

attached patch fixes the problem.

fix build/install/running of CDPlayer

Sebastian Reitenbach — Thu, 19 May 2011 18:04:19 -0000

the patch to the GNUmakefile and to the Info.plist file, fix the usage of the SystemPreferences.
The patches to the cddb.h/m files are the same as for cddb.bundle as from the patch I just sent in the other report.
The patch to player.m fixes building with gcc-2.95 on sparc

All tested on OpenBSD -current i386 and sparc

would be great if those patches could make it into a new release.

Patches for cddb.bundle to compile and install correctly.

Sebastian Reitenbach — Thu, 19 May 2011 17:57:13 -0000

Compilation of cddb.bundle failed on OpenBSD, i386, gcc-4.2.1. With attached patches, it worked well, tested with CDPlayer. It seems the compiler did not liked the variable named bool.
Further, the BUNDLE_INSTALL_DIR variable is removed from the GNUmakefile, since its not used anymore, and actually confuses gnustep-make where to put those files.

attached patch addresses both problems