Recent changes to 25: Override mtime with zip -X and SOURCE_DATE_EPOCH

#25 Override mtime with zip -X and SOURCE_DATE_EPOCH

Bernhard M. Wiedemann — Sun, 13 Feb 2022 09:41:08 -0000

There was a bug in the 1st scandir call param: "." vs n
https://github.com/distropatches/zip/commit/5063c9ce12c58f2512c2d00080d863d14b5d31f7

#25 Override mtime with zip -X and SOURCE_DATE_EPOCH

Mingye Wang — Sun, 26 Jan 2020 15:15:00 -0000

Oops! Yeah, my patches are based on zip 3.1d beta. You can find that version on the info-zip FTP (beta) or via https://antinode.info/ftp/info-zip.

#25 Override mtime with zip -X and SOURCE_DATE_EPOCH

Bernhard M. Wiedemann — Sun, 26 Jan 2020 01:01:42 -0000

also worth mentioning that I once imported our openSUSE package patches into git to make the chaos more manageable:
https://github.com/distropatches/zip/commits/opensuse

otherwise it looks more like
https://github.com/bmwiedemann/openSUSE/tree/master/packages/z/zip

#25 Override mtime with zip -X and SOURCE_DATE_EPOCH

Bernhard M. Wiedemann — Sat, 25 Jan 2020 20:50:10 -0000

The 0002 patch does not apply cleanly on my 3.0 - Is there a git repo of your version somewhere?

and then there are 2 problems:
1) there is another closedir(d) in the first loop.
2) the char *e; definition is still needed when you assign namelist[i]->d_name to it

There is a scandir impl in
https://github.com/microsoft/Windows-classic-samples/blob/master/Samples/Win7Samples/begin/sdkdiff/scandir.cpp but licence is probably not suitable. There are some other ports around on the net as part of the various libcs.

#25 Override mtime with zip -X and SOURCE_DATE_EPOCH

Arthur (Mingye) Wang — Sat, 25 Jan 2020 15:10:09 -0000

Got the scandir patch here. You will need to fill in the fallback implementation part.

#25 Override mtime with zip -X and SOURCE_DATE_EPOCH

Arthur (Mingye) Wang — Sat, 25 Jan 2020 10:27:25 -0000

A revised patch with manpage updates is attached.

Readdir seems a bit hard to fix generally, since it is used in a bit too many places. For Unix we can probably take the FreeBSD scandir() implementation and wrap a new readd() around it. Too keep the states we will need to make a struct around DIR instead so we know where the namelist is.

Override mtime with zip -X and SOURCE_DATE_EPOCH

Bernhard M. Wiedemann — Tue, 14 May 2019 12:31:19 -0000

This makes reproducible zip file creation a lot easier.
(the other common problem is non-deterministic recursion because it uses filesystem readdir order without sorting)