https://sourceforge.net/p/java-jml/bugs/24/2009-02-12T12:09:58ZRecent changes to 24: BasicMessenger#sendText(Email, String)2009-02-12T12:09:58Z2009-02-12T12:09:58Zzhiye xiehttps://sourceforge.net/u/jimuzhiye/https://sourceforge.net1f9cc570fe8150c8fb3444daf3cf73528669eb89

<div class="markdown_content"><p>hi all,<br /> if I send serveral messages at the beginning, the msn cannot receive messages. I debugged BasicMessenger#sendText(Email, String) and got what was the matter.</p> <p>public void sendText(final Email email, final String text) {<br /> if (email == null || text == null)<br /> return;<br /> MsnSwitchboard[] switchboards = getActiveSwitchboards();<br /> for (MsnSwitchboard switchboard1 : switchboards) {<br /> if (switchboard1.containContact(email)<br /> &amp;&amp; switchboard1.getAllContacts().length == 1) {<br /> switchboard1.sendText(text);<br /> return;<br /> }<br /> }</p> <p>final Object attachment = new Object();<br /> addSwitchboardListener(new MsnSwitchboardAdapter() {</p> <p>@Override<br /> public void switchboardStarted(MsnSwitchboard switchboard) {<br /> if (switchboard.getAttachment() == attachment) {<br /> switchboard.inviteContact(email);<br /> }<br /> }</p> <p>@Override<br /> public void contactJoinSwitchboard(MsnSwitchboard switchboard,<br /> MsnContact contact) {<br /> if (switchboard.getAttachment() == attachment<br /> &amp;&amp; email.equals(contact.getEmail())) {<br /> switchboard.setAttachment(null);<br /> removeSwitchboardListener(this);<br /> switchboard.sendText(text);<br /> }<br /> }</p> <p>});<br /> newSwitchboard(attachment);<br /> }</p> <p>each time the last line "newSwitchboard(attachment) is called, the attachment of switchboard will changed, so switchboard.getAttachment() == attachment always causes false.</p> <p>so I removed switchboard.getAttachment() == attachment in switchboardStarted and contactJoinSwitchboard, then the BasicMessenger#sendText(Email, String) works fine.</p> <p>But I wonder whether this modification will cause another bugs.</p></div>