Recent changes to patches

Null pointer exception occur when reading offline message

ronaldo — Wed, 16 Mar 2011 13:33:59 -0000

Because of M$ changed the ID from "pptoken2" to "Compact2", so please amend accordingly.

Wait for ADL payload

Anonymous — Tue, 06 Apr 2010 10:11:03 -0000

Patch for: https://sourceforge.net/projects/java-jml/forums/forum/405891/topic/3649716/index/page/1

Creates no more than 8 switchboards per minute

Damian Minkov — Wed, 13 Jan 2010 08:53:35 -0000

There is a rate for creating switchboards its 8 for minute. This patch obey this rate.
http://msnpiki.msnfanatic.com/index.php/Reference:Error_List
The error is : 800 126\r\n
"Also when requesting too many switchboard sessions. You can request up to 8 switchboard sessions in any 60-second period. Failed requests (i.e. requests that receive this error in reply) also count towards this limit. "

Contact list retrieving problems for MSNP>=13

James Lopez — Wed, 06 Jan 2010 18:15:36 -0000

There was some issues like bad ADL handling (no handling at all) for long contact lists (more than 220 approx.) so now multiple ADLs are sent following MSNPiki protocol.
There are also an error 241 that was previously treated but still was there, there was related to a RL list user only! A bad BL user? I suppose it was because a bad client handling before connecting to a JML client.
There're still some issues handling the contact list flags, comparing to other clients raw log when sending the ADL, we should check that if there was people on the list we don't expect.
I hope this work for you all too, that issues were really significant as the user gets disconnected by the server with any of those!

StringUtils.urlDecode bug fix

ronaldo — Tue, 05 Jan 2010 08:16:41 -0000

In mix language environment the original URLDecoder.decode() cannot work perfectly.
I submit this patch for enhance this function.

Get Personal message and display picture work in MSNP>10

James Lopez — Mon, 04 Jan 2010 23:23:52 -0000

DP was not working in MSNP>10, there was some problems between personal message and DP, so it was not possible to make it work.
DP, PM and display name are related things in the after-login process that requires for MSNP>13 some changes in the init process, for MSNP<13 too, even this was done in the SYNC command as it was before.
There're perhaps more things in this patch like the new setInitDisplayName, and setInitPersonalMessage now should work on all MSNP>9
Anyway there're still issues to improve.

Remove usage of non-api SUN class

The light in the dark — Tue, 08 Dec 2009 08:13:49 -0000

The StringUtils class uses a non-api class from Sun to access a system property.
Possibly this class will not be available in OpenJDK.
The class is truly simplistic, simple to copy and provides no benefits.

Offline message sent date

ronaldo — Fri, 18 Sep 2009 14:37:18 -0000

Extract the offline message sent date and return it to the listener class

Sending unicode offline message

ronaldo — Thu, 13 Aug 2009 07:15:20 -0000

In order to send unicode offline message, we can modify the method getOfflineMsg of the class
net.sf.jml.protocol.soap.OIM as follow.

private String getOfflineMsg(Email email, String txt)
{
StringBuilder mess = new StringBuilder();
String displayName=new String();
try
{
displayName=new String(Base64.encode(session.getMessenger().getOwner().getDisplayName().getBytes("UTF-8")));
txt=new String(Base64.encode(txt.getBytes("UTF-8")));
}
catch (UnsupportedEncodingException uee)
{
uee.printStackTrace();
}
mess.append("<?xml version=\"1.0\" encoding=\"utf-8\"?>\r\n");
mess.append("<soap:Envelope xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\r\n xmlns:xsd=\"http://www.w3.org/2001/XMLSchema\"\r\n xmlns:soap=\"http://schemas.xmlsoap.org/soap/envelope/\" >");
mess.append(" <soap:Header>");

mess.append(" <From memberName=\"" + session.getMessenger().getOwner().getEmail().getEmailAddress()
+ "\" friendlyName=\"=?utf-8?B?" + displayName + "?=\"\r\n xml:lang=\"nl-nl\"\r\n proxy=\"MSNMSGR\"\r\n xmlns=\"http://messenger.msn.com/ws/2004/09/oim/\"\r\n msnpVer=\"MSNP15\"\r\n buildVer=\"8.5.1288.816\"/>");
mess.append(" <To memberName=\""+ email.getEmailAddress() + "\" xmlns=\"http://messenger.msn.com/ws/2004/09/oim/\"/>");
mess.append(" <Ticket passport=\"" + sso.getOimTicket().replaceAll("&", "&") + "\"\r\n appid=\"PROD0119GSJUC$18\"\r\n lockkey=\"" + lockkey + "\"\r\n xmlns=\"http://messenger.msn.com/ws/2004/09/oim/\"/>");
mess.append(" <Sequence xmlns=\"http://schemas.xmlsoap.org/ws/2003/03/rm\">\r\n");
mess.append(" <Identifier xmlns=\"http://schemas.xmlsoap.org/ws/2002/07/utility\">http://messenger.msn.com</Identifier>\r\n");
mess.append(" <MessageNumber>" + sentMsgNumber + "</MessageNumber>\r\n");
mess.append(" </Sequence>\r\n");
mess.append(" </soap:Header>\r\n");
mess.append(" <soap:Body>\r\n");
mess.append(" <MessageType xmlns=\"http://messenger.msn.com/ws/2004/09/oim/\">text</MessageType>\r\n");
mess.append(" <Content xmlns=\"http://messenger.msn.com/ws/2004/09/oim/\">MIME-Version: 1.0\r\n");
mess.append("Content-Type: text/plain; charset=UTF-8\r\n");
mess.append("Content-Transfer-Encoding: base64\r\n");
mess.append("X-OIM-Message-Type: OfflineMessage\r\n");
mess.append("X-OIM-Run-Id: {3A3BE82C-684D-4F4F-8005-CBE8D4F82BAD}\r\n");
mess.append("X-OIM-Sequence-Num: " + sentMsgNumber + "\r\n\r\n");
mess.append(" " + txt + "");
mess.append(" </Content>");

mess.append(" </soap:Body>");
mess.append("</soap:Envelope>");

return mess.toString();
}

xmlUnescaping : add codes

Mon, 10 Aug 2009 19:14:57 -0000

in StringUtils.java

public static String xmlUnescaping(String text){
text = text.replaceAll("&","&");
text = text.replaceAll("<","<");
text = text.replaceAll(">",">");
text = text.replaceAll(""","\"");
text = text.replaceAll("'","\'");

text = text.replaceAll("&","&");
text = text.replaceAll(":",":");
text = text.replaceAll(";",";");
text = text.replaceAll("<","<");
text = text.replaceAll("=","=");
text = text.replaceAll(">",">");
text = text.replaceAll("?","?");
text = text.replaceAll("[","[");
text = text.replaceAll("\","\\");
text = text.replaceAll("]","]");
text = text.replaceAll("^","^");
text = text.replaceAll("{","{");
text = text.replaceAll("}","|");
text = text.replaceAll("~","}");

return text;
}