Recent changes to patches

#6 [PATCH] Use install(TARGETS) to install the kshutdown binary

Konrad Twardowski — Tue, 11 Oct 2016 05:39:22 -0000

status: open --> closed
Group: -->

[PATCH] Use install(TARGETS) to install the kshutdown binary

Raphael Kubo da Costa — Sun, 09 Oct 2016 11:27:18 -0000

The attached patch switches the INSTALL(PROGRAMS) calls in src/CMakeLists.txt to calls to INSTALL(TARGETS).

CMake's documentation for INSTALL(PROGRAMS) says:

This form is intended to install programs that are not
targets, such as shell scripts. Use the TARGETS form to install targets built
within the project.

Additionally, installing a target also causes CMake to create additional targets, suchas install/strip, to automatically strip the binary (useful for packagers and people building in release mode).

[PATCH] Use install(TARGETS) to install the kshutdown binary

Raphael Kubo da Costa — Sun, 09 Oct 2016 11:27:18 -0000

Ticket 6 has been modified: [PATCH] Use install(TARGETS) to install the kshutdown binary
Edited By: Konrad Twardowski (kdt)
Status updated: u'open' => u'closed'

#5 Please adjust kshutdown.desktop

Konrad Twardowski — Wed, 25 May 2016 07:44:07 -0000

status: open --> closed
Group: -->

#5 Please adjust kshutdown.desktop

nemysis — Sun, 22 May 2016 20:21:54 -0000

This is better patch

Please adjust kshutdown.desktop

nemysis — Sun, 22 May 2016 15:45:55 -0000

Please adjust kshutdown.desktop with enclosed patch
kshutdown-src_kshutdown.desktop.patch

I get without patch

[  186s] ERROR: No sufficient Category definition: /home/abuild/rpmbuild/BUILDROOT/kshutdown-3.99.1beta-0.x86_64//usr/share/applications/kshutdown.desktop 
[  186s] Errors in installed desktop file detected. Please refer to http://en.opensuse.org/SUSE_Package_Conventions/RPM_Macros

Please adjust kshutdown.desktop

nemysis — Sun, 22 May 2016 15:45:55 -0000

Ticket 5 has been modified: Please adjust kshutdown.desktop
Edited By: Konrad Twardowski (kdt)
Status updated: u'open' => u'closed'

#4 cmake: support Qt5 build

Konrad Twardowski — Wed, 30 Sep 2015 17:42:45 -0000

status: open --> closed
Group: -->

#4 cmake: support Qt5 build

Konrad Twardowski — Mon, 28 Apr 2014 14:09:19 -0000

Hi,
I finally applied the v2 patch.
http://sourceforge.net/p/kshutdown/code/735/
Thanks :)

I have little problem about naming, because you using KShutdown-qt for qt version

kshutdown-qt is still a "secondary" version and it should be installed independently to primary kshutdown-kde.

Also icons instalation isn't done yet.

See src/src.pro file for icon paths.

Errata:

install(FILES kshutdown.desktop DESTINATION ${XDG_APPS_INSTALL_DIR})

It should install kshutdown-qt.desktop

set(DATA_INSTALL_DIR ${CMAKE_INSTALL_PREFIX}/share/apps CACHE FILEPATH "Replacement for KDE4 variable")

For kshutdown-qt it should be
${CMAKE_INSTALL_PREFIX}/share/kshutdown but it's currently unused anyway...

set(XDG_APPS_INSTALL_DIR ${DATA_INSTALL_DIR}/share/applications CACHE FILEPATH "Install path for .desktop files")

This is probably a copy-paste bug:
${DATA_INSTALL_DIR}/share/applications

#4 cmake: support Qt5 build

Anonymous — Tue, 22 Apr 2014 21:31:34 -0000

Well, I have little problem about naming, because you using KShutdown-qt for qt version. I'll try figure that someway. Also icons instalation isn't done yet.