Recent changes to patches

#56 Fix Bashism in configure

Sam James — Mon, 26 Sep 2022 10:58:09 -0000

Thank you very much!

#56 Fix Bashism in configure

Jan Kara — Mon, 26 Sep 2022 08:23:43 -0000

status: open --> closed-accepted
Group: -->

#56 Fix Bashism in configure

Sam James — Sun, 25 Sep 2022 03:55:32 -0000

Sure, thanks!

Signed-off-by: Sam James <sam@gentoo.org>

#56 Fix Bashism in configure

Jan Kara — Fri, 23 Sep 2022 10:58:18 -0000

Thanks for the patch! It looks good. Can you please provide your attribution (Signed-off-by line) so that I can include it in the repository? Thanks!

Fix Bashism in configure

Sam James — Fri, 23 Sep 2022 02:31:37 -0000

configure scripts need to be runnable with a POSIX-compliant /bin/sh.

On many (but not all!) systems, /bin/sh is provided by Bash, so errors
like this aren't spotted. Notably Debian defaults to /bin/sh provided
by dash which doesn't tolerate such bashisms as '=='.

This retains compatibility with bash.

Fixes configure warnings/errors like:

configure: WARNING: tcpd.h not found
./configure: 8453: test: X: unexpected operator
checking that generated files are newer than configure... done

Patch attached, thanks!

Fix Bashism in configure

Sam James — Fri, 23 Sep 2022 02:31:37 -0000

Ticket 56 has been modified: Fix Bashism in configure
Edited By: Jan Kara (jkar8572)
Status updated: 'open' => 'closed-accepted'

#55 Fix compilation when using musl libc

Jan Kara — Mon, 30 Nov 2020 15:41:38 -0000

status: open --> closed-fixed
Group: -->

#55 Fix compilation when using musl libc

Jan Kara — Mon, 30 Nov 2020 15:41:13 -0000

Thanks for the patch but defining P() to nop is just pointless. I've instead just dropped P() usage and the include as well from quota.h.

Fix compilation when using musl libc

Anonymous — Thu, 26 Nov 2020 18:34:15 -0000

This patch fixes quota.h trying to include the sys/cdefs.h header which is a glibc internal header so it fails to compile when using any other libc (such as musl in my case). Since it's internal, that header should not be used by any user code anyway, if I read correctly.

2xsaiko

Fix compilation when using musl libc

Anonymous — Thu, 26 Nov 2020 18:34:15 -0000

Ticket 55 has been modified: Fix compilation when using musl libc
Edited By: Jan Kara (jkar8572)
Status updated: u'open' => u'closed-fixed'