Recent changes to patches

#357 Destructor ordering fix

Earnie Boyd — Wed, 13 Feb 2013 19:09:24 -0000

status: open --> closed
milestone: --> 64bit_readiness

#338 fix for [ 1500271 ] gdb crashes in windows xp 64

Earnie Boyd — Wed, 13 Feb 2013 18:43:12 -0000

status: open --> closed
milestone: --> 64bit_readiness

#416 patch: fix quoting and handle spaces in path gracefully

Hamish B — Sat, 02 Feb 2013 02:24:15 -0000

[see ongoing disucssion in #1109 "error if msys is installed in directory with spaces"]

to reiterate, the primary purpose of this patch is to at least make the thing fail gracefully if the msys devs decide not to do anything about the quoted path name problem. (which IMNSHO is just good defensive coding practice regardless of the platform)

regards,
Hamish

Improve performance of __write_memory

Anonymous — Fri, 31 Aug 2012 14:29:48 -0000

pseudo-reloc.c is responsible for The slow startup of program with its inefficient implementation of __write_memory.
current implementation of __write_memory doesn't have any states needed to decide whether current memory region requested to write already set writeable by previous __write_memory. so auto_protect_for function do the stateful decision of whether the region need update of protection itself again.
This patch previously confirmed with my cygwin build, and showed reasonable speedup of initialization of clang compiler which has 3000~ entries of pseudo-relocation.

winnls.h: add GetDateFormatEx() and more

George Koehler — Wed, 22 Aug 2012 20:19:50 -0000

This patch adds GetDateFormatEx() and some other functions and constants to include\winnls.h. Many of these functions first appeared in Windows Vista, and take locale names (LPCWSTR) rather than local identifiers (LCID).

Sources:
MSDN: http://msdn.microsoft.com/en-us/library/windows/desktop/dd319081%28v=vs.85%29.aspx
PInvoke.net: http://pinvoke.net/default.aspx/kernel32/EnumSystemLocalesEx.html
Stack Overflow: http://xrl.us/bnkt8a

Additional sources for NORM_LINGUISTIC_CASING:
MSDN: http://blogs.msdn.com/b/michkap/archive/2004/12/03/274288.aspx
Wikipedia: https://en.wikipedia.org/wiki/Turkish_dotted_and_dotless_I

MSDN was my main source of information. MSDN gave names for all functions, and types for all their arguments. MSDN also gave names for all constants, but not the values of many constants.

For flags, I tried passing 1 << 0, 1 << 1, 1 << 2, ..., 1 << 31, until I found values that seemed to work. Many functions give errors for invalid flags, thus eliminating many values for flags. After I found possible values, I checked some flags against PInvoke.net or Stack Overflow. I used PInvoke.net to confirm that LOCALE_ALL is zero; MSDN said that zero acts like LOCALE_ALL, but I had feared that LOCALE_ALL had a nonzero value. Meanwhile, FIND_FROMSTART is not zero. FIND_FROMSTART has no effect by itself (as it is already the default), but FIND_FROMSTART | FIND_FROMEND causes an error.

In an earlier post (https://sourceforge.net/mailarchive/message.php?msg_id=29680667), I wrote about how I found the value for NORM_LINGUISTIC_CASING, with help from MSDN and Wikipedia. In L"tr-TR" locale, L"i" and L"I" are not equal when LINGUSITIC_IGNORECASE | NORM_LINGUISTIC_CASING.

MSDN said that LOCALE_NAME_MAX_LENGTH is 85, and LOCALE_INVARIANT is 0x7f. I passed 0x7f to LCIDToLocaleName(), and got L"". I passed L"" to LocaleNameToLCID(), and got 0x7f again. Therefore, LOCALE_NAME_INVARIANT is L"". This matches the value from Stack Overflow.

I am missing the values of three constants. LOCALE_REPLACEMENT must either be 0x8, or any flag from 0x40 to 0x80000000. Stack Overflow claims that LOCALE_NAME_USER_DEFAULT is NULL, and LOCALE_NAME_SYSTEM_DEFAULT is L"!sys-default-locale". While NULL might be correct or wrong, L"!sys-default-locale" seems to be wrong. So, I have no values for these three constants.

2012-08-22 George Koehler <xkernigh@netscape.net>

\* include/winnls.h \[WINVER &gt;= 0x0501\] \(LOCALE\_INVARIANT\): Define.
\[WINVER &gt;= 0x0600\] \(LINGUISTIC\_IGNORECASE, LINGUISTIC\_IGNOREDIALECTIC,
FIND\_STARTSWITH, FIND\_ENDSWITH, FIND\_FROMSTART, FIND\_FROMEND,
NORM\_LINGUISTIC\_CASING, LOCALE\_ALL, LOCALE\_WINDOWS,
LOCALE\_SUPPLEMENTAL, LOCALE\_ALTERNATE\_SORTS, LOCALE\_NAME\_INVARIANT,
LOCALE\_NAME\_MAX\_LENGTH, CALINFO\_ENUMPROCEXEX, DATEFMT\_ENUMPROCEXEX,
LOCALE\_ENUMPROCEX, TIMEFMT\_ENUMPROCEX, CompareStringEx,
CompareStringOrdinal, EnumCalendarInfoExEx, EnumDateFormatsExEx,
EnumSystemLocalesEx, EnumTimeFormatsEx, FindNLSString, FindNLSStringEx,
GetCalendarInfoEx, GetDateFormatEx, GetTimeFormatEx, LCIDToLocaleName,
LocaleNameToLCID\): Define.
\[WINVER &gt;= 0x0600\] \(LOCALE\_REPLACEMENT, LOCALE\_NAME\_SYSTEM\_DEFAULT,
LOCALE\_NAME\_USER\_DEFAULT\): Document these constants in comments, but
with unknown values.
\[WINVER &gt;= 0x0601\] \(SORT\_DIGITSASNUMBERS, LOCALE\_NEUTRALDATA,
LOCALE\_SPECIFICDATA, LOCALE\_ALLOW\_NEUTRAL\_NAMES, FindStringOrdinal\):
Define.

Inside the attachment:
add-nls/add-nls.diff: output from cvs diff -u
add-nls/ChangeLog.txt: ChangeLog entry
add-nls/extra/*.c: small test programs

Windows Installer import library

Josue Andrade Gomes — Wed, 15 Aug 2012 19:48:36 -0000

Windows Installer (formerly Microsoft Installer) import library.
.DEF generated from Windows 2003 Server MSI.DLL
.H from scratch from publicly available information (MSDN)

winnls.h 64bit version

F.Mensik — Wed, 08 Aug 2012 05:45:57 -0000

there is a bug in winnls.h file. LONG_PTR is defined only for 32bit Windows not for 64bit Windows.

Remove possibility of other compilers and some _WIN64

Earnie Boyd — Tue, 24 Jul 2012 12:48:07 -0000

Ensure that our SDK can only be used by GCC and some _WIN64 uniqueness changes.

Note some white space changes have also been made.

Some inttypes need 64 bit indicators

Earnie Boyd — Tue, 24 Jul 2012 12:39:29 -0000

A few items like PRNdPTR and SCNdPTR need 64 bitness specified.

timeradd/timersub macros for sys/time.h

Carlo Bramini — Sat, 21 Jul 2012 14:00:32 -0000

I would like to suggest to add macros timeradd() and timersub() in sys/time.h
These macros may be useful for compiling some stuff, for example they are a requirement for compiling natively xine-lib for Windows.
Information about how these macros must work has been taken from the sources of cygwin.

Sincerely,

Carlo Bramini.