Recent changes to 605: php8 null access prohibited

#605 php8 null access prohibited

Tomasz Babczyński — Fri, 14 Oct 2022 16:34:35 -0000

Gerry, it is a surprise to me, because I'm sure it worked some time ago. I don't remember which version of php I had back then. It is possible that 6.x or even 5.x.

T.B.

#605 php8 null access prohibited

Gerry Kroll — Fri, 14 Oct 2022 13:38:41 -0000

assigned_to: Gerry Kroll
Attachments has changed:

Diff:

--- old
+++ new
@@ -0,0 +1 @@
+placecheck.zip (4.7 kB; application/x-zip-compressed)

php8 null access prohibited

Tomasz Babczyński — Fri, 14 Oct 2022 11:38:42 -0000

Hi,
I've found error in modules/googlemap/placecheck.php. If there are places in gedcom absent in the places db table, errors occur about line 288 and later in the mentioned file. $row is null but the code is trying to index it. I'm surprised that it ever worked (but worked, I did used it in the past). Indexing null was illegal before php8, maybe from php7? Summing up, I propose to use "safe objedct" pattern adding the following lines (shown with one line context) after 281 line of the placecheck.php file (with correct indent of course, I can't paste it properly here):
->fetchOneRow(PDO::FETCH_ASSOC);
if(is_null($row)) {
$row = array('pl_id'=>'', 'pl_place'=>'', 'pl_long'=>0, 'pl_lati'=>'', 'pl_placerequested'=>$levels[$z]);
}
if (!empty($row['pl_id'])) {

T.B.

php8 null access prohibited

Tomasz Babczyński — Fri, 14 Oct 2022 11:38:42 -0000

Ticket 605 has been modified: php8 null access prohibited
Edited By: Gerry Kroll (canajun2eh)
Owner updated: None => 'canajun2eh'