Recent changes to 896: TOra's build system sets $$ORIGIN value, which provides 'bad substitution' error message

#896 TOra's build system sets $$ORIGIN value, which provides 'bad substitution' error message

Ivan Brezina — Tue, 23 Feb 2016 16:50:12 -0000

status: open --> pending-postponed
Group: -->

#896 TOra's build system sets $$ORIGIN value, which provides 'bad substitution' error message

Ivan Brezina — Tue, 23 Feb 2016 16:46:06 -0000

I recall I added both $ORIGIN and $$ORIGIN because cmake might be very cryptic sometimes, when it comes to handling special characters. This guarantees, that then poracle plugin will work regarless of cmake version being used.

There in so way how to load Oracle client lib libclntsh.so via dlopen. Also there is not way how to change LD_LIBRARY_PATH from runing application. Therefore the plugin poracle.so uses $ORIGIN to point onlo library symlink named libclntsh.so. Then when poracle.so is loaded, libclntsh.so is loaded too.

This works even if there is no LD_LIBRARY_PATH pointing into ORACLE_HOME.
And you can switch between various oracle clients libs without changing system env. variables.

Lets leave this ticket open for a while. "fixing" it might broke other distros using different version of cmake.

TOra's build system sets $$ORIGIN value, which provides 'bad substitution' error message

Starikov Sergey — Tue, 12 May 2015 10:20:16 -0000

Building dev-db/tora (up to recent live version) with dev-util/cmake-2.8.12.2-r1 provides the following error messages:

/var/db/pkg/dev-db/tora-3.0.0_pre20140929/NEEDED.ELF.2: $: bad substitution
/var/db/pkg/dev-db/tora-3.0.0_pre20140929/NEEDED.ELF.2: $: bad substitution
/var/db/pkg/dev-db/tora-3.0.0_pre20140929/NEEDED.ELF.2: $: bad substitution

The following update of build scripts:

# bug 547520
grep -rlZ '$$ORIGIN' . | xargs -0 sed -i 's|:$$ORIGIN[^:"]*||' || \ die 'Removal of $$ORIGIN failed'

Fixes issue.

See downstream bug #547520 → bug #542796 for details.

To my mind this fix should be included by upstream.

TOra's build system sets $$ORIGIN value, which provides 'bad substitution' error message

Starikov Sergey — Tue, 12 May 2015 10:20:16 -0000

Ticket 896 has been modified: TOra's build system sets $$ORIGIN value, which provides 'bad substitution' error message
Edited By: Ivan Brezina (ibre5041)
Status updated: u'open' => u'pending-postponed'