#3 Improve C99 compatibility of configure script

Eli Schwartz — Fri, 26 Apr 2024 14:58:26 -0000

Slightly more worrisome:

/bin/sh ../libtool --tag=CC --mode=compile x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I../include -I./../include -I../include   -DXBAE_PER_CELL    -march=native -fstack-protector-all -O2 -pipe -fdiagnostics-color=always -frecord-gcc-switches -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing  -Wformat -Werror=format-security -Werror=implicit-function-declaration -Werror=implicit-int -Werror=int-conversion -Werror=incompatible-pointer-types -Wall -c -o Methods.lo Methods.c
 x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I. -I../include -I./../include -I../include -DXBAE_PER_CELL -march=native -fstack-protector-all -O2 -pipe -fdiagnostics-color=always -frecord-gcc-switches -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing -Wformat -Werror=format-security -Werror=implicit-function-declaration -Werror=implicit-int -Werror=int-conversion -Werror=incompatible-pointer-types -Wall -c Methods.c  -fPIC -DPIC -o .libs/Methods.o
Methods.c: In function 'DoEditCell':
Methods.c:1691:62: error: passing argument 1 of 'xbaeEventToRowColumn' from incompatible pointer type [-Werror=incompatible-pointer-types]
 1691 |                                         xbaeEventToRowColumn(mw, event, &r, &c, &x, &y);
      |                                                              ^~
      |                                                              |
      |                                                              XbaeMatrixWidget {aka struct _XbaeMatrixRec *}
In file included from Methods.c:50:
../include/Xbae/Utils.h:74:33: note: expected 'Widget' {aka 'struct _WidgetRec *'} but argument is of type 'XbaeMatrixWidget' {aka 'struct _XbaeMatrixRec *'}
   74 | int xbaeEventToRowColumn(Widget w, XEvent * event, int *row, int *column, int *x, int *y);
      |                          ~~~~~~~^
cc1: some warnings being treated as errors
make[1]: *** [Makefile:333: Methods.lo] Error 1
make[1]: Leaving directory '/var/tmp/portage/x11-libs/xbae-4.60.4/work/xbae-4.60.4/src'

The configure script would be nice if it could be autoreconf'ed from source, but it appears this requires the lesstif aclocal macros and in practice no one installs lesstif anymore, given motif was opened, so the macro won't exist in /usr/share.

Improve C99 compatibility of configure script

Florian Weimer — Thu, 16 Feb 2023 12:01:09 -0000

The attached patch fixes an implicit declaration of the exit function in the libXp/rc=XpQueryVersion autoconf probe. Future compilers will not support implicit function declarations by default, causing the probe to always fail.

It also includes fixes that are equivalent to what newer autoconf versions would generate, also required for C99 compatibility.

Related to:

Recent changes to 3: Improve C99 compatibility of configure script

#3 Improve C99 compatibility of configure script

Improve C99 compatibility of configure script